HyukjinKwon opened a new pull request, #80: URL: https://github.com/apache/spark-connect-rust/pull/80
### What changes were proposed in this pull request? `cargo test -p apache-spark-connect` currently fails to **compile** on `master`, breaking `Rust build and test`, `Rust checks`, `WASM UDF feature`, and the `Coverage` job: ``` error[E0599]: no method named `set_metrics` found for struct `observation::Observation` error[E0599]: no method named `set_dataframe` found for struct `observation::Observation` ``` This is a semantic merge conflict between two PRs that were each green in isolation: - **SPARK-59075** added an inline `#[cfg(test)]` test in `observation.rs` that calls the `pub(crate)` methods `Observation::set_metrics` / `set_dataframe` (which existed at its base). - **SPARK-59076** removed those two methods as unused dead code (they had no production callers). Merged together, the test references methods that no longer exist. This drops the obsolete `set_metrics_and_dataframe` test. Re-adding the methods would be the wrong fix: they are dead code with no callers, so they would reintroduce the `dead_code` warning that SPARK-59076's `deny(warnings)` now rejects. I confirmed `set_metrics`/`set_dataframe` are the only symbols SPARK-59076 removed (so this is the sole break), and that no other reference to them remains in the tree. ### Why are the changes needed? `master` does not compile its test targets; CI is red across multiple jobs. ### Does this PR introduce _any_ user-facing change? No. Removes a stale unit test only. ### How was this patch tested? `cargo fmt --all --check` passes. The removed test was the only compile error reported by the failing job, and `git grep` confirms no remaining references to the removed methods; CI on this PR verifies the build is green again. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
