dongjoon-hyun opened a new pull request, #58386: URL: https://github.com/apache/spark/pull/58386
### What changes were proposed in this pull request? This PR adds an `a.btn:hover` rule to `webui.css` so that an anchor styled as a Bootstrap button keeps the button hover style instead of the link underline. ### Why are the changes needed? Bootstrap 5 resets the underline on the `.btn` base rule, whose specificity `(0,1,0)` loses to the global `a:hover` rule in `webui.css` at `(0,1,1)`, and `.btn:hover` declares only `color`, `background-color`, and `border-color`. So every `<a class="btn ...">` is underlined on hover. The new rule is `(0,2,1)` and wins, while leaving plain links untouched. This is a regression from SPARK-55753 (Bootstrap 4.6.2 to 5.3.8); Bootstrap 4 declared `text-decoration: none` on `.btn:hover` itself, at a specificity that won. Two buttons are affected: "Open in new tab" in the executor detail offcanvas (`executorspage.js`) and `Download` in the History Server's Event Log column (`historypage.js`). All other `btn` usages are `<button>` elements, which were never affected. ### Does this PR introduce _any_ user-facing change? Yes. Hovering an anchor styled as a button no longer underlines its label; it now renders the standard Bootstrap button hover state. Compared to released versions, this fixes "Open in new tab" in the executor detail offcanvas, underlined on hover since Spark 4.2.0. ### How was this patch tested? Manually verified in Chrome against the real `bootstrap.min.css` and `webui.css`. Computed style of the hovered `btn-outline-secondary` anchor: | Property | Before | After | | --- | --- | --- | | `background-color` | `rgb(108, 117, 125)` | `rgb(108, 117, 125)` | | `color` | `rgb(255, 255, 255)` | `rgb(255, 255, 255)` | | `text-decoration-line` | `underline` | `none` | Also confirmed that a plain link still underlines on hover, and that the behavior is identical under `data-bs-theme="dark"`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
