nchammas commented on PR #58352:
URL: https://github.com/apache/spark/pull/58352#issuecomment-5455088866
@HyukjinKwon / @panbingkun - It seems this script has been broken at least
since #57581 and maybe for longer.
To get it to work locally, I needed to:
- add `--build-context root="${SPARK_HOME}"`
- add `--load`
- update Python from 3.11 to 3.12
Since this doesn't run on CI, I think no one noticed the breakage.
I would prefer to remove the `build-docs` script entirely. The added layer
of indirection + the fact that it doesn't run on CI means it will constantly be
breaking for one reason or another. I also don't see the need for the script as
a single Python venv under `docs/` (or even at the root of the project)
addresses the original motivation presented in #48860.
I won't open a PR for that, however, unless you agree. I know that some
people strongly prefer to use Docker for everything. I am not one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
