HyukjinKwon opened a new pull request, #84:
URL: https://github.com/apache/spark-connect-rust/pull/84
### What changes were proposed in this pull request?
Add a typed `branch` input to the Release workflow's manual dispatch, and
route every source checkout through a new `resolve-source` job:
- **Manual dispatch** now fetches the typed branch (e.g. `master` or
`branch-4.2`) from **apache/spark-connect-rust**, instead of using whatever the
committer's fork checkout happens to contain. The workflow still *runs* from
the fork, so it keeps using the fork's `CARGO_REGISTRY_TOKEN` /
`PYPI_API_TOKEN`.
- **Tag push** is unchanged: it releases the tagged commit on the fork the
tag was pushed to.
The repository/ref decision is made in exactly one place (`resolve-source`)
and consumed by `validate-version`, `publish-crates`, `build-wheels`, and
`build-sdist`. `publish-github-release` runs only on tag push (fork@tag) and
needs no change; `publish-wheels` only downloads artifacts.
### Why are the changes needed?
The dispatch dialog had no way to choose the source, so a fork-dispatched
release could silently ship the fork's stale copy rather than the canonical
apache code. Following the Apache Spark model, the committer's fork holds the
publish tokens, but the code being released should come from the upstream repo.
### Does this PR introduce _any_ user-facing change?
No. This only affects how a release is cut.
### How was this patch tested?
- `python3 -c "import yaml;
yaml.safe_load(open('.github/workflows/release.yml'))"` parses cleanly.
- Verified the job DAG and that the four source-checkout jobs reference
`needs.resolve-source.outputs`.
Fetching a public repo (apache/spark-connect-rust) with the fork's
`GITHUB_TOKEN` works because public repos are readable by any token.
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
