cloud-fan commented on code in PR #58404:
URL: https://github.com/apache/spark/pull/58404#discussion_r3897659814
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -341,7 +341,7 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
}
case j @ ExtractSingleColumnNullAwareAntiJoin(leftKeys, rightKeys)
- if canBroadcastBySize(j.right, conf) =>
+ if canPlanAsBroadcastHashJoin(j, conf) =>
Review Comment:
Addressed in the current revision. `canPlanAsBroadcastHashJoin` now requires
`canBroadcastBySize` on the right side, so a nonempty RHS with threshold zero
stays on `BroadcastNestedLoopJoinExec`. I also added signed-zero result
coverage for `-0.0` versus `0.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
