HyukjinKwon opened a new pull request, #91:
URL: https://github.com/apache/spark-connect-rust/pull/91
### What changes were proposed in this pull request?
Follow-up of #89 (SPARK-59117), which set an explicit `__module__` on the
PyO3
classes to the reference pyspark path. Two older offline tests in
`python/tests/test_dropin_offline.py` still asserted the pre-59117
`__module__ == "builtins"` and now fail in CI:
- `test_catalog_result_classes`: `CatalogMetadata` / `Database` / `Table` /
`Function` / `TablePartition` now report `pyspark.sql.catalog`.
- `test_python_eval_type_constants`: `PythonEvalType` now reports
`pyspark.util`.
This updates both to assert the reference module paths.
### Why are the changes needed?
The coverage job fails on `master` (and therefore on every PR branched from
it — e.g.
#90) at these two assertions. The expected values were verified against the
`#[pyclass(module = "...")]` declarations in `crates/pyspark-rs/src`
(`catalog.rs`,
`eval_type.rs`), and are consistent with the tests SPARK-59117 itself added
(`test_class_module_matches_reference_path` and the
`test_no_pyclass_reports_builtins_module`
guard, both of which pass).
### Does this PR introduce _any_ user-facing change?
No. Test-only change; no source behavior change.
### How was this patch tested?
`python -m py_compile` on the test file. The corrected expected values match
both the
Rust `module = "..."` declarations and the failing CI assertions
(`'pyspark.sql.catalog' == 'builtins'`, `'pyspark.util' == 'builtins'`).
Full suite
runs in CI.
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
