nchammas commented on code in PR #56174: URL: https://github.com/apache/spark/pull/56174#discussion_r3906470556
########## python/pyspark/sql/connect/protobuf/functions.py: ########## @@ -24,6 +24,7 @@ from pyspark.sql.column import Column from pyspark.sql.connect.functions.builtin import _invoke_function, _options_to_col, _to_col, lit from pyspark.sql.protobuf import functions as PyProtobufFunctions +from pyspark.sql.protobuf.functions import _read_descriptor_set_file Review Comment: Nit: We've already imported the functions just above. Perhaps we should just use that reference instead of adding a separate import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
