uros-b commented on PR #58449: URL: https://github.com/apache/spark/pull/58449#issuecomment-5508234753
Okay, here's the plan - I extended the current PR to cover a wider range of occurrences under the SQL component. Of course please note the caution here, as some `.size == 0` are numeric field comparisons, not collection emptiness. For example, Dongjoon's list above includes `CostBasedJoinReorder's planCost.size == 0`, where `size` is a cost field. Also, please note that Java collections have no `.nonEmpty`, so I needed to use `!.isEmpty` instead in a few cases. In any case, for other components, let's visit those in separate PRs, such as: - CORE: https://github.com/apache/spark/pull/58470 - MLLIB: https://github.com/apache/spark/pull/58471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
