LuciferYang commented on PR #55924: URL: https://github.com/apache/spark/pull/55924#issuecomment-5509907998
The new long-prefix tests only exercise readBinary/skipBinary, while readGeoData now follows the same buffer protocol. Two interactions have no coverage: a geometry column with null or skipped rows interleaves skipBinary with readGeoData on the same reader (prevBuf then alternates between exact-size wkb arrays and grown buffers), and PARQUET-246 cross-page recovery has never been tested on the geo path. testGeo variants with null rows and with a page boundary (or one variant containing both) would close the two gaps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
