viirya opened a new pull request, #18: URL: https://github.com/apache/spark-connect-gateway/pull/18
### What changes were proposed in this pull request? `crates/proxy/tests/tracing_integration.rs` verifies the gateway's OpenTelemetry behaviour end to end — that a forwarded RPC emits application spans, and that the W3C `traceparent` is propagated to the backend. It is `#[ignore]` by default, so it has never run in CI. The reason it opts out of workspace-wide runs is a Cargo feature-unification effect, **not** a flaky test: `cargo test --workspace` puts `kube` in the dependency graph, which transitively enables `opentelemetry`'s `spec_unstable_logs_enabled`. The `tracing-opentelemetry` that then links silently drops application spans, so only h2-internal spans reach the in-memory exporter and the assertions fail. Built on its own, the test passes. This adds a step to the `integration` job (added in SPARK-59161) that runs the test with its own package-scoped cargo invocation: ``` cargo test -p scg-proxy --test tracing_integration -- --ignored ``` The `#[ignore]` marker stays, so workspace-wide runs remain reliable. The job is also renamed from "integration tests (Docker)" to **"integration tests"** — this test needs no Docker, and the job now covers integration tests that simply need their own cargo invocation. Each step still says what it needs. ### Why are the changes needed? Tracing is the gateway's main debugging surface in production, and span emission plus `traceparent` propagation had no CI coverage at all. A regression there is invisible until someone tries to debug a live request. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Verified both directions locally, confirming the documented behaviour: ``` cargo test -p scg-proxy --test tracing_integration -- --ignored # 1 passed cargo test --workspace --test tracing_integration -- --ignored # FAILED ``` The first is what CI now runs. This PR's own CI run exercises the new step. ### Was this patch authored or co-authored using generative AI tooling? Yes, co-authored with Claude Code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
