szehon-ho commented on code in PR #58385:
URL: https://github.com/apache/spark/pull/58385#discussion_r3920290360
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -14858,6 +15263,10 @@ object functions {
* @since 4.0.0
* @return
* Returns a column of the type specified by the `targetType` argument.
+ *
+ * @note
+ * Affected by these public SQL configurations:
+ * - `spark.sql.timestampType`
Review Comment:
[P2] `VariantGet` is also affected by `spark.sql.session.timeZone`. It is a
`TimeZoneAwareExpression`, and its `VariantCastArgs` passes the resolved
`zoneId` into timestamp-related casts (for example, casting a variant string to
`TIMESTAMP_LTZ`). Could you add the session-time-zone configuration to all
`variant_get` / `try_variant_get` Scala overloads and their Python docstrings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
