LuciferYang commented on PR #58445: URL: https://github.com/apache/spark/pull/58445#issuecomment-5519705535
> +1, LGTM. Thank you, @LuciferYang. The shared `unionRDDs` helper and the point about reading `outputPartitioning` before the children execute both look right to me. > > One small request before merging: could you refresh the PR description to match the latest commits? The "What changes" section does not mention the shared helper, and "How was this patch tested" still says the new test compares against the same query with `spark.sql.unionOutputPartitioning` off, while the test now pins its expected rows. The PR description has been updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
