ulysses-you commented on PR #58279: URL: https://github.com/apache/spark/pull/58279#issuecomment-5524806973
Everything from the re-review is addressed in 83ed83560db: **Finding 3 (Blocking)** -- fixed as suggested: the positions projecting the pre-alignment keys come from the innermost grouping, falling back to the spec's when there is none; `partiallyClusteredSpec` is gone. Revert-verified: without it the updated subset test throws the measured `PartitioningCollection` invariant, and the second split for id = 1 makes the test fail on master as well. **Finding 4** -- the replicate-side test is now master-level and still pins the guard; data details in the inline reply. **Finding 5** -- agreed, follow-up: deriving `isGrouped` from the emitted partitions, or asserting `splits.size <= numSplits`, would localise a wrong expected count at the node instead of three steps downstream. **Finding 6** -- updating the JIRA affects versions to 4.2.0 / 4.3.0; backports follow, with a skew-based repro for branch-4.2 as noted. **Finding 7 / 8** -- the shape notation now ends both chains at the hidden `GroupPartitionsExec`, and the `applyGroupPartitions` scaladoc describes the descent. Local suites green: `KeyGroupedPartitioningSuite`, `EnsureRequirementsSuite`, `GroupPartitionsExecSuite` (203). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
