anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5530942568
Thanks for the review @cloud-fan , have addressed the architectural concern by extracting a lightweight `MultiColumnInSubqueryEvaluator` that excludes `plan/BaseSubqueryExec` from codegen references, so task closures no longer carry the driver's physical subquery plan. Verified the shared-Nondeterministic-identity risk you flagged with a Java serialization round-trip test confirming `ctx.references` preserves object identity across the driver/executor boundary. Also added the fully-non-null-RHS late-mismatch regression, fixed the early-return in the legacy empty-RHS path, and corrected the Case A comment. 11/11 tests pass. Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
