LuciferYang commented on PR #58424: URL: https://github.com/apache/spark/pull/58424#issuecomment-5548572662
Compared to the precedent of RewriteNonCorrelatedExists (11 lines, always-on), this rule is three hand-curated whitelists plus a private config covering a single TPC-DS shape, and each whitelist silently narrows as Spark adds new expressions and types. I agree with opt-in (see my comment on the cost gate), but the PR description should state the promotion or removal criterion for this flag: what measured win on real workloads graduates it, and what has to be solved before it can default on. Otherwise it stays experimental, and no one is willing to touch or delete it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
