LuciferYang commented on PR #58489: URL: https://github.com/apache/spark/pull/58489#issuecomment-5548582479
**6. initInformer ignores `stopped`, and the test's intercept scope masks it** `resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/InformerManager.scala:43` After `stopInformer()`, `stopped=true` and `informer=null`, so a later `initInformer` silently builds an informer that can never start (blocked by `stopped`) and is never closed. Production code doesn't do this today, but the suite's "Calling startInformer after stopInformer should throw" wraps both `initInformer` and `startInformer` in one `intercept`, so it passes regardless of which one throws and hides exactly this gap. Could you make `initInformer` throw when stopped (or explicitly allow revival), with the test asserting the two steps separately? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
