uros-b commented on PR #58282: URL: https://github.com/apache/spark/pull/58282#issuecomment-5569224580
<details><summary>0 blocking, 0 non-blocking, 0 nits.</summary> Clean, well-scoped change: it lifts an over-strict assertion so a bare main error class resolves to its main template, brings getMessageTemplate in line with its sibling reader methods, turns the two previously-asserting malformed cases into clear errors, and adds a focused test. Backward-compatible (only formerly-erroring paths change), and the sole design question — whether to allow bare conditions given the mix of existing patterns — was debated and resolved by committer consensus, with README guidance deferred to a separate PR. Traced getMessageTemplate against its callers and its siblings. The only behavior changes are on paths that previously hit the removed assertion: a bare main class that defines sub-classes now returns the main template, and the two malformed sub-class references now throw a clear SparkException instead of an AssertionError. Every previously-successful call — a bare main class with no sub-classes, and MAIN.SUB — returns the same result, so the change is backward-compatible. No subclass overrides getMessageTemplate. Inline comments: None. Existing feedback coverage: 17/17 adjudicated. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
