zahed1994 commented on code in PR #58176: URL: https://github.com/apache/spark/pull/58176#discussion_r3949747480
########## sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/VectorizedReaderCapacityOverflowException.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.vectorized; + +import org.apache.spark.annotation.DeveloperApi; + +/** + * Exception thrown when the vectorized reader capacity is exhausted or cannot be reserved. + */ +@DeveloperApi Review Comment: Good point. The exception is only intended as an internal marker so DataSourceUtils can distinguish genuine vectorized reader capacity exhaustion from corrupt input; it is not intended as a user-facing/developer API. I'll remove the @DeveloperApi annotation and keep the exception internal to the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
