pavan51 commented on PR #57346:
URL: https://github.com/apache/spark/pull/57346#issuecomment-5573374519
@peter-toth Thanks for the final review! Both optional items are now
addressed:
• Finding 28: Pinned WINDOW_MONOTONIC_DEQUE_ENABLED -> false in the
naiveResult baseline arm of checkFallbackEquivalence to ensure it stays a true
two-path baseline regardless of future default flips.
• Finding 29: Updated the benchmark results link in the PR description to
use the absolute apache/spark/blob/master/... URL so it correctly resolves.
• Benchmarks & CI: I also re-ran the benchmark workflow so the results
file is once again the tip commit. The PR is fully synced with master and CI is
completely green.
Let me know if there's anything else needed before merge!***
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
