pan3793 commented on PR #58580: URL: https://github.com/apache/spark/pull/58580#issuecomment-5580739864
Thanks for the careful review. 1, 2: ab04d459d28d8cc8c3a6b90142fe2804a28f7cb8 adds `UnwrapCastInBinaryComparison.unwrapCastInSet`, which returns the column and the converted values (empty when no row can match). The rule's `InSet` branch is built on it, so the caller no longer matches any expression shape, and the contract is in its scaladoc. 3: the unwrap now only runs when the child is a `Cast`; the bare-column path is unchanged, and a test pins the pushed order. `InSubqueryExec.inSet` is the evaluation-side object, so the translation builds its own. 4: same root cause, different shape, since the comparison rule can yield range predicates. Filed SPARK-59317 as a follow-up. 5: blank line restored; values are fetched only for handled children, so an unsupported child warns as before; the description now says the Catalyst-filter variant evaluates the cast itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
