HyukjinKwon commented on PR #58602: URL: https://github.com/apache/spark/pull/58602#issuecomment-5581880359
Closing after further review: the schema conversion here recurses over a finite protobuf descriptor, so it is bounded by the schema rather than by input data, and recursive message types are already handled (a repeated record name is rejected by default). The added total-depth bound provides no additional coverage and can drop fields from legitimate deeply-nested non-recursive schemas when recursiveFieldMaxDepth is set. Not worth the behavior change; closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
