uros-b commented on code in PR #58349:
URL: https://github.com/apache/spark/pull/58349#discussion_r3959523966
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala:
##########
@@ -764,47 +764,47 @@ class ParquetFilters(
case ParquetByteType | ParquetShortType | ParquetIntegerType =>
(n: Array[String], values: Array[Any]) =>
- val set = new HashSet[Integer]()
+ val set = Sets.newHashSetWithExpectedSize[Integer](values.length)
Review Comment:
On another note, there is a completeness gap. TypedParquetFilterOps.makeIn
is still unsized. Current master extracted Time / timestamp-nanos IN pushdown
into TypedParquetFilterOps.makeIn:
```
override def makeIn(columnPath: Array[String], values: Array[Any]):
FilterPredicate = {
val set = new HashSet[T]()
values.foreach(v => set.add(toPhysicalOrNull(v)))
FilterApi.in(column(columnPath), set)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
