SEPURI-SAI-KRISHNA commented on PR #58149: URL: https://github.com/apache/spark/pull/58149#issuecomment-5596553638
@uros-b opened #58649 for `branch-4.2`. The conflict was not in the NaN change itself. On master `vectorInfNorm` returns `Double` because SPARK-58544 widened the accumulators there, and that change is not on `branch-4.2`, so the cherry-pick could not apply. The backport therefore keeps the `float` accumulator and changes only the NaN-skipping comparison to `Math.max`, and its test additions cover the SPARK-58897 cases only, leaving out the SPARK-58544 section that sits above them in master's `vector-norm.sql`. I regenerated the golden files on `branch-4.2` and checked that the diff is purely additive. Every new expectation, value and schema type alike, matches what the same query produces on master, so keeping `float` here gives identical results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
