uros-b commented on PR #56422: URL: https://github.com/apache/spark/pull/56422#issuecomment-5603139974
Pushdown should go through the Types Framework, not seven copied match arms The description says each builder was widened to ParquetTimeMicrosType | ParquetTimeMicrosTypeAdjToUTC. The diff instead adds a second, duplicated arm after FrameworkFilterOps. filterOpsFor is an exact match on timeType(false, MICROS), so true never hits TimeTypeParquetOps.filterOps. Register a second ParquetFilterOps with timeType(true, MICROS) (same toLong / acceptsValue as the existing micros ops) in filterOpsList. Then ParquetFilters needs no extra cases, isMicrosResolution lives in one place, and this stays aligned with “framework types need no per-type changes in ParquetFilters.” -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
