vranes commented on code in PR #58660:
URL: https://github.com/apache/spark/pull/58660#discussion_r3972459862
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1876,6 +1876,23 @@ case class BinBy(
override def producedAttributes: AttributeSet =
AttributeSet(scaledDistributeColumns ++ appendedAttributes)
+ override protected def stringArgs: Iterator[Any] = {
+ val zone = timeZoneId.getOrElse("UTC")
+ val fmt =
TimestampFormatter.getFractionFormatter(DateTimeUtils.getZoneId(zone))
+ def ref(a: Attribute): String = s"${a.name}#${a.exprId.id}"
+
+ Iterator(
+ s"range=[${ref(rangeStart)}, ${ref(rangeEnd)}]",
+ "binWidth=" + IntervalUtils.toDayTimeIntervalString(
+ binWidthMicros, IntervalStringStyles.ANSI_STYLE,
+ DayTimeIntervalType.DAY, DayTimeIntervalType.SECOND),
+ s"alignTo=${fmt.format(originMicros)}",
+ s"distribute=[${distributeColumns.map(ref).mkString(", ")}]",
+ s"scaledDistribute=[${scaledDistributeColumns.map(ref).mkString(", ")}]",
+ s"appends=[${appendedAttributes.map(ref).mkString(", ")}]",
+ s"zone=$zone")
+ }
+
Review Comment:
What I meant by "no user-facing changes" is the fact that the operator is
still unreleased and behind a gate (off by default), but technically you are
right, updated the description. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
