HyukjinKwon commented on code in PR #58414:
URL: https://github.com/apache/spark/pull/58414#discussion_r3973951443


##########
docs/sql-migration-guide.md:
##########
@@ -22,6 +22,10 @@ license: |
 * Table of contents
 {:toc}
 
+## Upgrading from Spark SQL 4.4 to 5.0
+
+- Since Spark 5.0, the Spark Thrift Server refuses to start when 
`hive.server2.enable.doAs` is `true` and `hive.server2.authentication` verifies 
user identities (anything other than `NONE`/`NOSASL`). It impersonates the 
connecting user for Hive metastore calls, but queries and the storage access 
they perform still run as the server's own service identity, so storage-level 
permissions are checked against the service principal rather than the 
connecting user (SPARK-5159). Spark 4.4 logs a warning for the same 
configuration. To restore the previous behavior, set 
`spark.sql.hive.thriftServer.allowIneffectiveDoAs` to `true`. Setting 
`hive.server2.enable.doAs` to `false` also starts the server, but note that it 
stops impersonating metastore calls as well, so it is not a no-op.

Review Comment:
   "Spark 4.4 logs a warning for the same configuration" — this PR targets 5.0 
and adds no warning anywhere (only the hard failure), so the 4.4 warning must 
be coming from a separate branch-4.x change. Is that companion already merged 
to branch-4.x? If it isn't, this note points users upgrading from 4.4 at 
behavior that doesn't exist there yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to