HyukjinKwon commented on code in PR #58619:
URL: https://github.com/apache/spark/pull/58619#discussion_r3974041877
##########
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleService.scala:
##########
@@ -83,18 +83,25 @@ class ExternalShuffleService(sparkConf: SparkConf,
securityManager: SecurityMana
/** Create a new shuffle block handler. Factored out for subclasses to
override. */
protected def newShuffleBlockHandler(conf: TransportConf):
ExternalBlockHandler = {
- // Constrain registered localDirs to the configured local directories.
+ // Constrain registered localDirs to the configured local directories and,
when
+ // spark.shuffle.service.requireAppScopedLocalDirs is enabled, to the
registering
+ // application's own per-app directory (the Worker creates executor local
dirs under a
+ // path containing the app id). The check is opt-in: executors launched by
Workers that
+ // predate the per-app layout register unscoped paths and would be
rejected, so enable it
+ // only once every Spark application is upgraded.
Review Comment:
The rollout unit is the Worker, not the application: the config doc and
`docs/spark-standalone.md` both say to upgrade every Worker first, and the
sentence just above already attributes the per-app layout to Workers.
```suggestion
// only once every Worker is upgraded.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
