pan3793 commented on PR #58661: URL: https://github.com/apache/spark/pull/58661#issuecomment-5617954391
Thanks @peter-toth. On the multi-insert result difference, agreed: my "no result difference" reply was wrong for that path, and honoring is not possible there since each insert runs as its own command. 0364b66b093 rejects `MATERIALIZED` wherever `CTESubstitution` inlines during analysis (multi-insert, commands that are not `CTEInChildren`, `spark.sql.legacy.inlineCTEInCommands`, and `spark.sql.legacy.ctePrecedencePolicy=LEGACY`) with `UNSUPPORTED_FEATURE.MATERIALIZED_CTE_ALWAYS_INLINED`, mirroring the existing recursive-CTE errors on the legacy paths. `NOT MATERIALIZED` stays accepted there. Multi-insert is covered in `cte-command.sql`, the configs in `CTEInlineSuite`. The `TreeNode` comment is updated in the same commit. On `NOT MATERIALIZED`, the doc sentence keeps stating that non-deterministic expressions may yield different values per reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
