subhramit commented on code in PR #58226:
URL: https://github.com/apache/spark/pull/58226#discussion_r3978926247
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala:
##########
@@ -124,7 +124,7 @@ class CSVOptions(
val extension = {
val ext = parameters.getOrElse(EXTENSION, "csv")
- if (ext.size != 3 && !ext.forall(_.isLetter)) {
+ if (ext.size != 3 || !ext.forall(_.isLetter)) {
Review Comment:
I don't know if that is a standard, but since three of us were aligned, I
pushed it in
https://github.com/apache/spark/pull/58226/commits/3994219073528e02fe551e3df95726f670043b2c
and updated the PR description. Since I am the ticket author as well, I will
update the expectation there.
You all can give an approval if it looks fine, YangJie can maybe provide any
final opinions once he is available (we can discuss and change if there is any
strong counter argument).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
