AnishMahto opened a new pull request, #58709:
URL: https://github.com/apache/spark/pull/58709

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'common/utils/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the 
guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   Part of the contract for the SCD2 version map is the keys in the version map 
should track exactly with the data column names.
   
   Complexity arises when case insensitivity is used, and the incoming 
microbatch has a different case-spelling for certain columns than the persisted 
target/aux tables.
   
   When `Scd2ForeachBatchHandler` does a [union with the incoming microbatch 
rows and the existing target/aux table 
rows|https://github.com/apache/spark/blob/master/sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/autocdc/Scd2ForeachBatchHandler.scala#L104-L106],
 due to ordering of the union operators, the resulting DF will respect the 
case-spelling on the incoming microbatch.
   
   But when this dataframe is eventually merged back into the target/aux 
tables, the existing case-spelling on those tables will win. This is no longer 
acceptable since the version map will be constructed by referencing column 
names in the microbatch dataframe. If those column names change, the version 
map's keys become inconsistent.
   
   The proposal is to union the target schema onto the microbatch dataframe 
during microbatch preprocessing, and before we eventually construct the version 
map. This appraoch has the added benefit that the version map will now see rows 
reductively schema evolved (i.e dropped) from the microbatch.
   
   This change is a no-op behaviorally, and should have no observable side 
effect to users.
   
   
   ### Why are the changes needed?
   SCD2 ignore-null support
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Unit tests.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   Co-authored with GPT-5.6 Sol.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to