dongjoon-hyun commented on code in PR #58620:
URL: https://github.com/apache/spark/pull/58620#discussion_r3985584702
##########
core/src/main/scala/org/apache/spark/internal/config/Deploy.scala:
##########
@@ -51,6 +51,20 @@ private[spark] object Deploy {
.checkValue(_ > 0, "spark.deploy.recoveryTimeout must be positive.")
.createOptional
+ val RECOVERY_SERIALIZATION_FILTER =
+ ConfigBuilder("spark.deploy.recoverySerializationFilter")
+ .doc("JEP-290 serialization filter pattern applied when the master
deserializes " +
+ "recovery state written by the built-in JavaSerializer (currently
enforced for " +
+ "the ZOOKEEPER recovery mode). The default allows only JDK, Scala and
Spark " +
+ "classes, which covers everything the master persists
(ApplicationInfo, " +
+ "DriverInfo, WorkerInfo and their fields); znodes containing anything
else are " +
+ "treated as corrupt and dropped during recovery. Set to '*' to disable
filtering. " +
+ "Introduced in 4.3.0; also available in 3.5.10, 4.0.5, 4.1.4 and
4.2.1; and in " +
Review Comment:
Could you remove the `Introduced in 4.3.0; also available in 3.5.10, 4.0.5,
4.1.4 and 4.2.1; ...` sentence here and in `docs/spark-standalone.md`? No other
config in `internal/config` documents backport versions like this, and it
commits to backports that have not been decided yet.
Also, `3.5.10` is not possible as written: `branch-3.5` still builds with
`java.version` 1.8, and `java.io.ObjectInputFilter` does not exist on JDK 8
(only `sun.misc.ObjectInputFilter`), @holdenk .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
