uros-b commented on code in PR #57261:
URL: https://github.com/apache/spark/pull/57261#discussion_r3988148551
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -3781,8 +3781,20 @@
},
"INVALID_BUCKET_COUNT" : {
Review Comment:
The non-integer path still inherits SQLSTATE 22003 here.
INVALID_BUCKET_COUNT.NON_INTEGER_LITERAL sits under a parent whose state is
22003 ("numeric value out of range"), but a non-integer bucket literal is a
type/parameter error, not a range violation — it should be
INVALID_PARAMETER_VALUE.INTEGER (SQLSTATE 22023, "expects an integer literal,
but got <invalidValue>"). Since sub-conditions can't declare their own
SQLSTATE, the two children can't get different states while grouped under one
INVALID_BUCKET_COUNT parent: the non-integer case needs to move out to
INVALID_PARAMETER_VALUE.INTEGER (renaming the message param describe →
invalidValue), while the genuine out-of-range case stays on 22003. This is
cloud-fan's blocking point from the Aug 6 review, and it's still the one thing
gating this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
