pan3793 commented on code in PR #58735:
URL: https://github.com/apache/spark/pull/58735#discussion_r3988488722
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushdownPredicatesAndPruneColumnsForCTEDef.scala:
##########
@@ -57,8 +57,8 @@ object PushdownPredicatesAndPruneColumnsForCTEDef extends
Rule[LogicalPlan] with
/**
* Gather all the predicates and referenced attributes on different points
of CTE references
- * using pattern `ScanOperation` (which takes care of determinism) and
combine those predicates
- * and attributes that belong to the same CTE definition.
+ * using pattern `PhysicalOperation` and combine those predicates and
attributes that belong
+ * to the same CTE definition.
Review Comment:
Correction to my reply above: SPARK-37670's fixVersions are 3.2.2 and 3.3.0,
not 3.4.0. I had read the master commit's tags and missed the backports. So the
rule has carried this since 3.2.2, and "affects 3.2.2 and later" -- wider than
what I first wrote. SPARK-39764 (3.4.0) is unrelated to the cause, as you said.
PR description and JIRA updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
