dongjoon-hyun commented on PR #58563: URL: https://github.com/apache/spark/pull/58563#issuecomment-5636503170
The doc changes look correct to me: all four `function` factories build a new `StateSpecImpl`, and all five builder methods return `this`. Could you retitle the PR before merge, e.g. `Add return tags to the public StateSpec methods`? `dev/merge_spark_pr.py` strips `@` from the PR body but not from the title, so `@return` would end up in the master commit subject and keep pinging the GitHub user `return`. Nit: the 2nd and 4th `function` overloads are also missing `@tparam KeyType`. It would be nice to add those here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
