sarutak commented on code in PR #58737:
URL: https://github.com/apache/spark/pull/58737#discussion_r3992763375
##########
core/src/main/scala/org/apache/spark/deploy/security/UserCredentialManager.scala:
##########
@@ -554,17 +554,14 @@ private[spark] object UserCredentialManager extends
Logging {
* raises a clear error prompting explicit configuration.
*
* @param sparkConf The Spark configuration to apply properties into. Not
modified when OIDC
- * credential propagation is disabled or when `isLocal` is
true.
- * @param isLocal Whether the application runs in local mode (no scheduler
backend that starts
- * a resolution phase).
+ * credential propagation is disabled.
* @return `Some(loader)` with the [[CredentialProviderLoader]] used, to be
passed to
* [[create]] so the resolution phase reuses the same loader; `None`
when OIDC is
- * disabled or when `isLocal` is true (no loader is allocated in
those cases).
+ * disabled (no loader is allocated in that case).
*/
def applyProviderProperties(
- sparkConf: SparkConf,
- isLocal: Boolean): Option[CredentialProviderLoader] = {
- if (!sparkConf.get(SECURITY_OIDC_ENABLED) || isLocal) {
+ sparkConf: SparkConf): Option[CredentialProviderLoader] = {
+ if (!sparkConf.get(SECURITY_OIDC_ENABLED)) {
Review Comment:
I've documented it rather than resolving earlier in local mode, since moving
resolution up would
diverge local from cluster and break the selection-vs-resolution separation
(resolution does I/O and
must stay late).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
