james-willis commented on code in PR #101:
URL: 
https://github.com/apache/spark-connect-rust/pull/101#discussion_r3991953624


##########
.github/workflows/release.yml:
##########
@@ -298,6 +298,27 @@ jobs:
             args+=(--zig)
           fi
           maturin build "${args[@]}"
+      - name: Set up free-threaded interpreters
+        if: runner.os == 'Linux'
+        uses: actions/setup-python@v5
+        with:
+          python-version: |
+            3.13t
+            3.14t
+      - name: Build free-threaded wheels with maturin
+        # The free-threaded (PEP 703) ABI is incompatible with abi3, so these 
are
+        # separate, version-specific cp313t/cp314t wheels; pyo3 ignores the 
abi3-py39
+        # feature when it detects a free-threaded interpreter. They land in 
the same
+        # dist/ and are uploaded alongside the abi3 wheel. Linux only for now 
--
+        # macOS/Windows free-threaded legs can follow.
+        if: runner.os == 'Linux'
+        shell: bash
+        run: |
+          args=(--release --out dist --target "${{ matrix.target }}" 
--interpreter python3.13t python3.14t)
+          if [[ "${{ matrix.zig }}" == "true" ]]; then

Review Comment:
   Had to make some tweaks like you suggest but now it is green.
   
   I will consume the CI-generated wheel for some testing now.



##########
.github/workflows/release.yml:
##########
@@ -298,6 +298,27 @@ jobs:
             args+=(--zig)
           fi
           maturin build "${args[@]}"
+      - name: Set up free-threaded interpreters
+        if: runner.os == 'Linux'
+        uses: actions/setup-python@v5
+        with:
+          python-version: |
+            3.13t
+            3.14t
+      - name: Build free-threaded wheels with maturin
+        # The free-threaded (PEP 703) ABI is incompatible with abi3, so these 
are
+        # separate, version-specific cp313t/cp314t wheels; pyo3 ignores the 
abi3-py39
+        # feature when it detects a free-threaded interpreter. They land in 
the same
+        # dist/ and are uploaded alongside the abi3 wheel. Linux only for now 
--
+        # macOS/Windows free-threaded legs can follow.
+        if: runner.os == 'Linux'
+        shell: bash
+        run: |
+          args=(--release --out dist --target "${{ matrix.target }}" 
--interpreter python3.13t python3.14t)
+          if [[ "${{ matrix.zig }}" == "true" ]]; then

Review Comment:
   Had to make some tweaks like you suggest but now it is green. 
https://github.com/james-willis/spark-connect-rust/actions/runs/34573809960
   
   I will consume the CI-generated wheel for some testing now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to