charliec05 commented on PR #58534: URL: https://github.com/apache/spark/pull/58534#issuecomment-5642695803
The initial CI failures exposed existing tests that depended on silently converting non-finite values to decimal nulls. I've updated that coverage to match the proposed ANSI behavior: - The Hive test now checks both ANSI `CAST_OVERFLOW` and non-ANSI null behavior. - The numeric SQL setup uses `TRY_CAST` to preserve its null expected-value rows; the six explicit non-finite casts still exercise ANSI errors. The execution and analyzer goldens were regenerated through `SQLQueryTestSuite`, including both Java 17 and Java 21 execution variants. - The Connect `lag`/`lead` cases now apply NaN defaults to the floating-point column, keeping the valid decimal cases intact. Local SQL query/analyzer, Hive, Thrift Server, and Connect window-function regressions all pass, as do Scala lint and Ruff. The PR description includes the validation commands. A new CI run will validate the full patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
