dongjoon-hyun commented on PR #58490: URL: https://github.com/apache/spark/pull/58490#issuecomment-5649561388
Thank you for making a PR, @uros-b . This change looks good to me. However, since the same pattern still remains in the other test suites of the `streaming` module, could you cover them together in this PR instead of making separate follow-up PRs? It would be better to handle this per module to reduce the churn. - `StateMapSuite.scala`: L140, L148, L172 (`shouldCompact === false`) - `StreamingContextSuite.scala`: L179 (`isStarted() === false`), L502 (`awaitTerminationOrTimeout(500) === false`) - `MapWithStateRDDSuite.scala`: L147, L149 (`functionCalled === false`) - `WriteAheadLogSuite.scala`: L311 (`hasNext === false`) Note that `RecurringTimerSuite.scala` L75 (`timer.invokePrivate(stopped()) === true`) should be kept as is, because `invokePrivate` is declared via `PrivateMethod[RecurringTimer]` and its static type is not `Boolean`. In that case, please update the PR title and description accordingly (e.g. `... in streaming module tests`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
