dongjoon-hyun opened a new pull request, #58768:
URL: https://github.com/apache/spark/pull/58768
### What changes were proposed in this pull request?
This PR removes the `SecurityManager` dependency from
`KubernetesExecutorBuilder` and `BasicExecutorFeatureStep`:
- Add `authSecret` to `KubernetesExecutorConf`.
- Resolve auth secret in `BasicExecutorFeatureStep` via
`KubernetesExecutorConf.authSecret` instead of `SecurityManager`.
- Remove `SecurityManager` parameter from
`KubernetesExecutorBuilder.buildFromFeatures` and `BasicExecutorFeatureStep`.
- Pass auth secret to `KubernetesConf.createExecutorConf` from pod
allocators.
### Why are the changes needed?
`KubernetesExecutorBuilder` and `BasicExecutorFeatureStep` only require
`SecurityManager` to read `secMgr.getSecretKey()`. Passing the whole
`SecurityManager` introduces unnecessary coupling and complicates unit testing.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Added unit tests in `KubernetesConfSuite` and
`BasicExecutorFeatureStepSuite`.
- Ran unit tests and scalastyle:
```bash
build/sbt -Pkubernetes kubernetes/scalastyle kubernetes/Test/scalastyle
build/sbt -Pkubernetes 'kubernetes/testOnly *KubernetesConfSuite
*KubernetesExecutorBuilderSuite *BasicExecutorFeatureStepSuite
*ExecutorPodsAllocatorSuite *DeploymentAllocatorSuite
*StatefulSetAllocatorSuite'
```
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Antigravity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
