sarutak commented on PR #58773:
URL: https://github.com/apache/spark/pull/58773#issuecomment-5662361817
Thanks for the symmetric promotion, @dongjoon-hyun. It mirrors
KubernetesDriverSpec cleanly.
One optional suggestion (non-blocking): since this is now a `@Stable`
`@DeveloperApi`, it might be worth pinning down two API contracts in the test
suite:
- `getExecutorKubernetesResourcesAsJavaList` returns a read-only view
(`.add(...) throws UnsupportedOperationException`)
- `create(...)` copies the input list, so later mutations of the caller's
list don't affect the spec.
These would guard against silent contract regressions if the internal
conversion ever changes. KubernetesDriverSpec/its suite don't cover these
either, so it may make sense to add them to both for symmetry, or skip if you'd
rather keep them aligned as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
