dejankrak-db commented on PR #58766: URL: https://github.com/apache/spark/pull/58766#issuecomment-5664615421
You're right, thanks for catching this. `asProperties` is a strict `val` evaluated at construction before `url`/`driverClass`, and it already throws `NULL_DATA_SOURCE_OPTION` for a null `url` (SPARK-48601), so the new `url == null` guard is unreachable and the test passes on master without the change. This was ported from an internal fork where `JDBCOptions` is structured differently, so it doesn't apply here. Closing as unnecessary -- thanks again for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
