gaogaotiantian commented on PR #58765:
URL: https://github.com/apache/spark/pull/58765#issuecomment-5669946664
1. There's a mypy failure - `f"datetime64[{unit}]"` is not guaranteed to be
valid (even though logically it probably is). We can probably ignore here, or
we can check `unit` and assign literals to this argument.
2. Is `ArrowDtype` timestamp commonly used now? This is a breaking change I
think. I mean our timestamp localization is a mess for naive timestamps. But
maybe this is not too bad.
3. Do we care about `us` vs `ns` thing? It bothers me a bit - the unit is
different but the result is the same - is it intentional?
4. We used the str interpolation for the result comparision -
`self.assertEqual(str(arrow_out.iloc[0]), str(numpy_out.iloc[0]))` why is that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
