jiangxt2 commented on code in PR #58028:
URL: https://github.com/apache/spark/pull/58028#discussion_r4011192582
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -1022,7 +1022,18 @@ case class Cast(
(d.toBigDecimal * MICROS_PER_SECOND).longValue
}
private[this] def doubleToTimestamp(d: Double): Any = {
Review Comment:
@gengliangwang Thanks for the review. I agree with your reasoning and accept
the preference to keep the legacy behavior unchanged. I will close this PR, and
any broader effort to address similar overflow cases can be revisited
separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
