dongjoon-hyun commented on PR #825: URL: https://github.com/apache/spark-kubernetes-operator/pull/825#issuecomment-5681875007
Thank you for the review, @peter-toth. Addressed in 8859867. - **1.** Kept the `or` resolution to preserve the documented `enabled: false` default and the `required` schema entry, and documented the precedence in `docs/operations.md`: a stale `enable: true` wins over `enabled: false` and must be removed to turn the feature off. This is stated both in the `dynamicConfig.enable` table row and in the NetworkPolicy section. - **2.** Added a paragraph to the NetworkPolicy section of `docs/operations.md` noting that `operatorDeployment.networkPolicy.enable` is deprecated but still honored. - **3.** Agreed that this is pre-existing and out of scope here. I'll file a separate JIRA for `operatorRbac.configManagement.create`. - **4.** Thanks for verifying the presence-check variant. I'll stay with `or` for this PR for the reasons in (1). - **5.** Filed SPARK-59533 to track the removal in chart `2.0.0` and linked it from the `values.yaml` comments, the `values.schema.json` descriptions, and `docs/operations.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
