dongjoon-hyun commented on PR #827: URL: https://github.com/apache/spark-kubernetes-operator/pull/827#issuecomment-5682793327
For Finding 6: I re-checked the doc source rather than the rendered page. The seventh marker in [integrate_a_custom_job.md](https://github.com/kubernetes-sigs/kueue/blob/main/site/content/en/docs/tasks/dev/integrate_a_custom_job.md?plain=1#L140) is `groups=events.k8s.io,resources=events,verbs=create;watch;update;patch`, and the built-in JobSet integration carries the same group at [jobset_controller.go#L59](https://github.com/kubernetes-sigs/kueue/blob/main/pkg/controller/jobs/jobset/jobset_controller.go#L59). So the group in the description is right: the chart grants core `events` only, which does not cover `events.k8s.io`, and the operator does not use that API. I'll keep the sentence as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
