dongjoon-hyun commented on PR #828: URL: https://github.com/apache/spark-kubernetes-operator/pull/828#issuecomment-5684180823
Thank you for the review, @peter-toth. All five findings are addressed in 5351a9a. 1. **No `.status` while suspended**: confirmed. `updateStatusFromCache` seeds the cache with the in-memory `Submitted` status and `patchAndStatusWithVersionLocked` short-circuits on equality, so a plain `persistStatus` in the hold branch is dropped. I took the second option for this PR: the two `*-suspended.yaml` assertions now check `spec.suspend: true` plus the existing `error:` checks on the driver pod and the StatefulSets. A dedicated `Suspended` state, which also fixes the blank state column, is planned as a follow-up together with the running-attempt suspend. 2. **Doc**: applied your suggestion. The PR description is updated the same way. 3. **App-side test**: added `AppInitStepTest.suspendedNonInitializingAppProceeds`. 4. **Log level**: both hold branches now log at `debug`. 5. **Shared assertions**: `spark-state-transition.yaml`, `spark-cluster-state-transition.yaml` and `spark-cluster-worker-statefulset.yaml` now take `($SPARK_APPLICATION_NAME)` / `($SPARK_CLUSTER_NAME)`, and `tests/e2e/suspend` reuses them. The `watched-namespaces` and `watched-namespaces-file` groups pass the new binding explicitly. The `spec.suspend: false` check moved into an inline `resource:` assert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
