AnishMahto commented on code in PR #58645: URL: https://github.com/apache/spark/pull/58645#discussion_r4019959488
########## sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/autocdc/AutoCdcSchemaUtils.scala: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.pipelines.autocdc + +import org.apache.spark.sql.types.StructType + +private[autocdc] object AutoCdcSchemaUtils { + + /** + * Enumerates every leaf path in `schema`, in schema order, as its sequence of name parts. + * Structs unfold recursively; every other type (including arrays and maps) is an opaque leaf. Review Comment: Fair, the function name is too generic for what its actually doing, and therefore misleading. Renamed to `flattenStructFieldPaths` to make it clear that recursing arrays/maps is not part of this function's contract. Open to other name suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
