peter-toth commented on code in PR #830:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/830#discussion_r4027295582
##########
.github/workflows/build_and_test.yml:
##########
@@ -290,6 +290,22 @@ jobs:
build-tools/helm/spark-kubernetes-operator/
minikube docker-env --unset
helm test spark
+ - name: Validate the deprecated helm key warning
+ if: matrix.test-group == 'configmap-metadata'
+ run: |
+ # `helm template` does not render NOTES.txt, so an install or
upgrade against a
Review Comment:
Moved to the `lint` job, description updated. One wrinkle: on helm 3.18.6
that command still fails with `Kubernetes cluster unreachable`, even with
`KUBECONFIG=/dev/null`. The runner has Helm 4.2.4 so CI is fine, but a local
run on helm 3.x will report a false failure.
##########
build-tools/helm/spark-kubernetes-operator/templates/NOTES.txt:
##########
@@ -0,0 +1,31 @@
+{{- /*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/ -}}
+Apache Spark Kubernetes Operator {{ .Chart.AppVersion }} is installed.
+{{- if hasKey .Values.operatorDeployment.networkPolicy "enable" }}
Review Comment:
Reproduced and fixed with `| default dict` on both toggles. `--set
operatorConfiguration.dynamicConfig=null` still fails, but identically on
`main`: `_helpers.tpl:137` reads `.dynamicConfig.source` unguarded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
