dongjoon-hyun commented on code in PR #833:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/833#discussion_r4029132677
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/utils/ConfigurableEventRecorder.java:
##########
@@ -94,6 +102,24 @@ private static boolean eventsEnabled() {
return Boolean.TRUE.equals(KUBERNETES_EVENTS_ENABLED.getValue());
}
+ private static boolean isExcluded(String reason) {
+ // A null resolved value is treated as an empty list.
+ return
Utils.sanitizeCommaSeparatedStrAsSet(KUBERNETES_EVENTS_EXCLUDED_REASONS.getValue())
Review Comment:
Thank you, @peter-toth. Addressed in 1b1a923. I switched to local comma
splitting so that `*` is reported like other invalid expressions, and added a
test and a doc note that `.*` is the way to exclude all reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
