sarutak commented on code in PR #58786:
URL: https://github.com/apache/spark/pull/58786#discussion_r4033790711
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -1689,6 +1696,55 @@ class JDBCSuite extends SharedSparkSession {
Some(TimestampType))
}
+ test("SPARK-57925: Oracle bare NUMBER legacy config restores scale=10") {
+ val oracleDialect = JdbcDialects.get("jdbc:oracle")
+ val metadata = new MetadataBuilder().putString("name",
"test_column").putLong("scale", -127)
+ withSQLConf(SQLConf.LEGACY_ORACLE_NUMBER_MAPPING_ENABLED.key -> "true") {
+ assert(oracleDialect.getCatalystType(java.sql.Types.NUMERIC, "numeric",
0, null) ==
+ Some(DecimalType(DecimalType.MAX_PRECISION, 10)))
+ assert(oracleDialect.getCatalystType(java.sql.Types.NUMERIC, "float", 1,
metadata) ==
+ Some(DecimalType(DecimalType.MAX_PRECISION, 10)))
+ }
+ }
+
+ test("SPARK-57925: Oracle bare NUMBER boundary - fraction preserved, large
int overflows") {
+ val oracleDialect = JdbcDialects.get("jdbc:oracle")
+ val result = oracleDialect.getCatalystType(java.sql.Types.NUMERIC,
"numeric", 0, null)
+ assert(result == Some(DecimalType(DecimalType.MAX_PRECISION,
DecimalType.DEFAULT_SCALE)))
+ val p = DecimalType.MAX_PRECISION
+ val newScale = DecimalType.DEFAULT_SCALE // 18
+ val oldScale = 10
+
+ // High-precision fraction: 15 fractional digits.
Review Comment:
One nit: the "15-digit fraction" wording is off. The test value
`0.000012345678912345` has 18 fractional digits (14 significant). It appears
both in the test comment and in the PR description's "How was this patch
tested?" section. The assertion itself is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
